[Wave9] Progress Bar UI #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re-mansion-labs/expensify-app-fork into wave9/header-progress-bar
MaciejSWM
changed the base branch from
wave-9/onboarding-flow
to
wave9/onboarding-flow
kowczarz
reviewed
Feb 9, 2024
Comment on lines
119
to
122
| shouldShowProgressBar: boolean; | ||
|
|
||
| /** 0 - 100 number indicating current progress of the progress bar */ | ||
| progressBarPercentage: number; |
There was a problem hiding this comment.
These are non-null props, but you're setting the default value here, not sure what was the purpose, but that's something that needs to be changed.
There was a problem hiding this comment.
- @mateuuszzzzz we will drop pair-props and stay with just one prop https://docs.google.com/document/d/1sxG_RV5HTFHgdCsJUDNpqSGs09W_OPLBKbNYQfu3FHw/edit#heading=h.qcbt20goffpx sorry for a late change
kowczarz
reviewed
Feb 19, 2024
| @@ -70,6 +71,33 @@ function HeaderWithBackButton({ | |||
| // If the icon is present, the header bar should be taller and use different font. | |||
| const isCentralPaneSettings = !!icon; | |||
|
|
|||
| let middleContent = null; | |||
There was a problem hiding this comment.
Suggested change
| let middleContent = null; | |
| let middleContent; |
Comment on lines
75
to
99
| if (progressBarPercentage) { | ||
| middleContent = ( | ||
| <View> | ||
| <View style={styles.progressBarWrapper}> | ||
| <View style={[{width: `${progressBarPercentage}%`}, styles.progressBar]} /> | ||
| </View> | ||
| </View> | ||
| ); | ||
| } else if (shouldShowAvatarWithDisplay) { | ||
| middleContent = ( | ||
| <AvatarWithDisplayName | ||
| report={report} | ||
| policy={policy} | ||
| shouldEnableDetailPageNavigation={shouldEnableDetailPageNavigation} | ||
| /> | ||
| ); | ||
| } else { | ||
| middleContent = ( | ||
| <Header | ||
| title={title} | ||
| subtitle={stepCounter ? translate('stepCounter', stepCounter) : subtitle} | ||
| textStyles={titleColor ? [StyleUtils.getTextColorStyle(titleColor)] : []} | ||
| /> | ||
| ); | ||
| } |
There was a problem hiding this comment.
I would consider wrapping it in useMemo
blazejkustra
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/expensify-swm/issue/EXP-274/[wave-9]-new-onboarding-flow-progress-bar-[just-the-ui]
UI and Storybook for the Progress bar. To test, easiest way is to
npm run storybookhttp://localhost:6006/?path=/story/components-headerwithbackbutton--progress-bar
Storybook seems to be broken after merge. Looks like it's broken on main as well. In this case best way to test is to do
progressBarPercentage = 25,insrc/components/HeaderWithBackButton/index.tsxand to open workspace switcher or any screen with header